fix(compiler): use strict equality for 'code' comparison #56944
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace loose equality (==) with strict equality (===) for the 'code' variable. This change ensures type safety and prevents unintended type coercion.
14 tasks
crisbeto
approved these changes
Jul 11, 2024
Contributor
|
This PR was merged into the repository by commit 107173c. The changes were merged into the following branches: main, 18.1.x |
atscott
pushed a commit
that referenced
this pull request
Jul 11, 2024
Replace loose equality (==) with strict equality (===) for the 'code' variable. This change ensures type safety and prevents unintended type coercion. PR Close #56944
This was referenced Aug 8, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The code uses a loose equality comparison (==) for the code variable.
Issue Number: N/A
What is the new behavior?
The code now uses strict equality comparison (===) for the code variable, ensuring type safety and preventing unintended type coercion.
Does this PR introduce a breaking change?
Other information
this was introduces in v18.1.0 release, in this PR:
#56764