fix(core): rename the equality function option in toSignal (#56769) #56922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6769) The option introduced in 5df3e78 has been named `equals` whereas the existing option in `signal` is named `equal`. This commit renames the new option to `equal` as well to keep the naming coherent across these APIs. PR Close angular#56769
Member
Author
|
Note: this is cherry-pick of #56769 to the v18.1.x branch (the original PR should have targeted rc instead of minor). |
crisbeto
approved these changes
Jul 10, 2024
Member
Author
|
This PR was merged into the repository by commit 4d87b9e. The changes were merged into the following branches: 18.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option introduced in 5df3e78 has been named
equalswhereas the existing option insignalis namedequal. This commit renames the new option toequalas well to keep the naming coherent across these APIs.PR Close #56769