Skip to content

Conversation

@thePunderWoman
Copy link
Contributor

In rare cases people may put let statements before else statements and omit semicolons, causing migration issues.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

In rare cases people may put let statements before else statements and omit semicolons, causing migration issues.
@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Jul 9, 2024
@thePunderWoman thePunderWoman requested a review from crisbeto July 9, 2024 15:01
@ngbot ngbot bot modified the milestone: Backlog Jul 9, 2024
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 9, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 5179ce3.

The changes were merged into the following branches: main, 18.0.x, 18.1.x

pkozlowski-opensource pushed a commit that referenced this pull request Jul 9, 2024
In rare cases people may put let statements before else statements and omit semicolons, causing migration issues.

PR Close #56913
pkozlowski-opensource pushed a commit that referenced this pull request Jul 9, 2024
In rare cases people may put let statements before else statements and omit semicolons, causing migration issues.

PR Close #56913
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 9, 2024
@thePunderWoman thePunderWoman deleted the cf-migration-let-fix branch October 22, 2024 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants