Skip to content

Conversation

@alan-agius4
Copy link
Contributor

In this update, the fetch backend now executes fetch operations outside of the Angular zone. This adjustment primarily aims to decrease Continuous Delivery (CD) cycles on Node.js. The decision was influenced by Undici, the Node.js fetch implementation, which relies on setTimeouts to manage response timeouts.

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jul 3, 2024
@alan-agius4 alan-agius4 changed the title perf(http): execute fetch outside Angular zone perf(http): execute fetch outside of Angular zone Jul 3, 2024
@angular-robot angular-robot bot added the area: performance Issues related to performance label Jul 3, 2024
@ngbot ngbot bot added this to the Backlog milestone Jul 3, 2024
In this update, the fetch backend now executes fetch operations outside of the Angular zone. This adjustment primarily aims to decrease Continuous Delivery (CD) cycles on Node.js. The decision was influenced by Undici, the Node.js fetch implementation, which relies on `setTimeouts` to manage response timeouts.
@alan-agius4 alan-agius4 force-pushed the fetch-outside-zone branch from ada047a to 4e2f65c Compare July 3, 2024 10:32
@alan-agius4 alan-agius4 added area: server Issues related to server-side rendering area: common/http Issues related to HTTP and HTTP Client action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 3, 2024
@alan-agius4 alan-agius4 marked this pull request as ready for review July 3, 2024 10:52
@pullapprove pullapprove bot requested a review from dylhunn July 3, 2024 10:52
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the investigation @alan-agius4 !

@alan-agius4 alan-agius4 removed the request for review from dylhunn July 4, 2024 07:13
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 4, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 6e1f78f.

The changes were merged into the following branches: main, 18.0.x, 18.1.x

pkozlowski-opensource pushed a commit that referenced this pull request Jul 4, 2024
In this update, the fetch backend now executes fetch operations outside of the Angular zone. This adjustment primarily aims to decrease Continuous Delivery (CD) cycles on Node.js. The decision was influenced by Undici, the Node.js fetch implementation, which relies on `setTimeouts` to manage response timeouts.

PR Close #56820
pkozlowski-opensource pushed a commit that referenced this pull request Jul 4, 2024
In this update, the fetch backend now executes fetch operations outside of the Angular zone. This adjustment primarily aims to decrease Continuous Delivery (CD) cycles on Node.js. The decision was influenced by Undici, the Node.js fetch implementation, which relies on `setTimeouts` to manage response timeouts.

PR Close #56820
@alan-agius4 alan-agius4 deleted the fetch-outside-zone branch July 4, 2024 10:13
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client area: performance Issues related to performance area: server Issues related to server-side rendering target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants