Skip to content

fix(common): typo in NgOptimizedImage warning #56756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cexbrayat wants to merge 1 commit into from
Closed

fix(common): typo in NgOptimizedImage warning #56756

cexbrayat wants to merge 1 commit into from

Conversation

@cexbrayat
Copy link
Member

@cexbrayat cexbrayat commented Jun 28, 2024

A space is missing in the warning message for TOO_MANY_PRIORITY_ATTRIBUTES.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The current warning is:

NG02966: NgOptimizedImage: The "priority" attribute is set to true more than 10 times (11 times). Marking too many images as "high" priority can hurt your application's LCP (https://web.dev/lcp)."Priority" should only be set on the image expected to be the page's LCP element.

Note the missing space before "Priority".

What is the new behavior?

Warning is fixed

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@cexbrayat
fix(common): typo in NgOptimizedImage warning
e09f88e 
A space is missing in the warning message for `TOO_MANY_PRIORITY_ATTRIBUTES`.
@pullapprove pullapprove bot requested a review from atscott June 28, 2024 16:17
@angular-robot angular-robot bot added the area: common Issues related to APIs in the @angular/common package label Jun 28, 2024
@ngbot ngbot bot added this to the Backlog milestone Jun 28, 2024
@AndrewKushnir AndrewKushnir removed the request for review from atscott June 28, 2024 17:37
@AndrewKushnir AndrewKushnir added target: minor This PR is targeted for the next minor release action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jun 28, 2024
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Jun 28, 2024

Caretaker note: low risk change (typo fix), no presubmit required.

@thePunderWoman
Copy link
Contributor

thePunderWoman commented Jun 28, 2024

This PR was merged into the repository by commit f25653e.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 29, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@cexbrayat @AndrewKushnir @thePunderWoman