fix(core): properly remove imports in the afterRender phase migration #56524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
reviewed
Jun 19, 2024
packages/core/schematics/migrations/after-render-phase/migration.ts
Outdated
Show resolved
Hide resolved
Before this commit, the migration was removing the `AfterRenderPhase` enum from the imports but not the comma, resulting in invalid code:
ts
```
import { , Directive, afterRender } from '@angular/core';
```
This commit fixes this by using `updateNamedImports` and `replaceNode` instead of `removeNode`.
After:
ts
```
import { Directive, afterRender } from '@angular/core';
```
2a9dcd9 to
7c7ba66
Compare
JoostK
approved these changes
Jun 19, 2024
Member
JoostK
left a comment
There was a problem hiding this comment.
I'm not a core code owner so probably my approval isn't sufficient, but LGTM and thanks for the fix!
Member
|
Joost's review is certainly sufficient (regardless of the group), so marking this PR as merge ready 😄 Thanks for the fix! |
Contributor
Contributor
|
This PR was merged into the repository by commit 03a2acd. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Before this commit, the migration was removing the
AfterRenderPhaseenum from the imports but not the comma, resulting in invalid code:ts
What is the new behavior?
This commit fixes this by using
updateNamedImportsandreplaceNodeinstead ofremoveNode.After:
ts
Does this PR introduce a breaking change?
Other information