fix(core): improve docs on afterRender hooks #56522
Conversation
This commit fixes a typo in the `AfterRenderPhase` deprecation warning and improves the documentation of the options parameter of the afterRender hooks (which are now all named `options` instead of being called `opts` in some functions and `options` in others).
AndrewKushnir
left a comment
There was a problem hiding this comment.
@cexbrayat thanks for the improvement 👍
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
|
Caretaker notes:
|
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-core
|
This PR was merged into the repository by commit 86bcfd3. The changes were merged into the following branches: main |
|
@cexbrayat there was a merge conflict with the 18.0.x branch, so this PR was merged into the main branch only. Could you please create a new PR and target the 18.0.x branch when you get a chance? Thank you. |
|
@AndrewKushnir Here it is #56525 As the main part of the PR is based on changes introduced in the next release, the new PR is really small (and maybe not worth it). |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The AfterPhaseRender deprecation warning has a typo.
What is the new behavior?
This commit fixes a typo in the
AfterRenderPhasedeprecation warning and improves the documentation of the options parameter of the afterRender hooks (which are now all namedoptionsinstead of being calledoptsin some functions andoptionsin others).Does this PR introduce a breaking change?
Other information