fix(router): Delay the view transition to ensure renders in microtask… #56494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s complete This commit delays makes two changes: * Use the `read` phase for `afterNextRender` hook. We really want to wait for any write hooks to complete before starting the animation * In addition, wait a macrotask before resolve (really, this makes the above change unnecessary but it's still conceptually the right thing). This ensures any follow-up rendering in the microtask queue is flushed before the animation starts. Important note: This only affects the timing of the animation start, delaying it longer to allow additional rendering/change detections to flush. This promise already resolves in an `afterNextRender` hook and is only used directly by the browser's view transition machinery.
AndrewKushnir
approved these changes
Jun 18, 2024
Contributor
|
This PR was merged into the repository by commit 0d52c6b. The changes were merged into the following branches: main, 18.0.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 20, 2024
…s complete (#56494) This commit delays makes two changes: * Use the `read` phase for `afterNextRender` hook. We really want to wait for any write hooks to complete before starting the animation * In addition, wait a macrotask before resolve (really, this makes the above change unnecessary but it's still conceptually the right thing). This ensures any follow-up rendering in the microtask queue is flushed before the animation starts. Important note: This only affects the timing of the animation start, delaying it longer to allow additional rendering/change detections to flush. This promise already resolves in an `afterNextRender` hook and is only used directly by the browser's view transition machinery. PR Close #56494
This was referenced Jul 12, 2024
This was referenced Jul 14, 2024
This was referenced Jul 15, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s complete
This commit delays makes two changes:
readphase forafterNextRenderhook. We really want to wait for any write hooks to complete before starting the animationImportant note: This only affects the timing of the animation start, delaying it longer to allow additional rendering/change detections to flush. This promise already resolves in an
afterNextRenderhook and is only used directly by the browser's view transition machinery.