fix(localize): add @angular/localize/init as polyfill in angular.json
#56300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…son` This commit addresses an issue where the `@angular/localize/init` polyfill is not included when there are no polyfills specified in the `angular.json` file.
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Jun 6, 2024
This commit addresses an issue where the `@angular/localize/init` polyfill is not included when there are no polyfills specified in the `angular.json` file. However, this approach has a drawback: the localize polyfill will always be added if it is found in a monorepo, even if an application does not use i18n. As a result, we will issue a warning to inform users about this behavior and encourage them to explicitly add it to their `polyfills` configuration. The `ng add` schematic will also be updated to add the polyfill as in the builders config, see: angular/angular#56300 Closes: angular#27786
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Jun 6, 2024
This commit addresses an issue where the `@angular/localize/init` polyfill is not included when there are no polyfills specified in the `angular.json` file. However, this approach has a drawback: the localize polyfill will always be added if it is found in a monorepo, even if an application does not use i18n. As a result, we will issue a warning to inform users about this behavior and encourage them to explicitly add it to their `polyfills` configuration. The `ng add` schematic will also be updated to add the polyfill as in the builders config, see: angular/angular#56300 Closes: angular#27786
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Jun 6, 2024
This commit addresses an issue where the `@angular/localize/init` polyfill is not included when there are no polyfills specified in the `angular.json` file. However, this approach has a drawback: the localize polyfill will always be added if it is found in a monorepo, even if an application does not use i18n. As a result, we will issue a warning to inform users about this behavior and encourage them to explicitly add it to their `polyfills` configuration. The `ng add` schematic will also be updated to add the polyfill as in the builders config, see: angular/angular#56300 Closes: angular#27786
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Jun 6, 2024
This commit addresses an issue where the `@angular/localize/init` polyfill is not included when there are no polyfills specified in the `angular.json` file. However, this approach has a drawback: the localize polyfill will always be added if it is found in a monorepo, even if an application does not use i18n. As a result, we will issue a warning to inform users about this behavior and encourage them to explicitly add it to their `polyfills` configuration. The `ng add` schematic will also be updated to add the polyfill as in the builders config, see: angular/angular#56300 Closes: angular#27786
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Jun 6, 2024
This commit addresses an issue where the `@angular/localize/init` polyfill is not included when there are no polyfills specified in the `angular.json` file. However, this approach has a drawback: the localize polyfill will always be added if it is found in a monorepo, even if an application does not use i18n. As a result, we will issue a warning to inform users about this behavior and encourage them to explicitly add it to their `polyfills` configuration. The `ng add` schematic will also be updated to add the polyfill as in the builders config, see: angular/angular#56300 Closes: angular#27786
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Jun 6, 2024
This commit addresses an issue where the `@angular/localize/init` polyfill is not included when there are no polyfills specified in the `angular.json` file. However, this approach has a drawback: the localize polyfill will always be added if it is found in a monorepo, even if an application does not use i18n. As a result, we will issue a warning to inform users about this behavior and encourage them to explicitly add it to their `polyfills` configuration. The `ng add` schematic will also be updated to add the polyfill as in the builders config, see: angular/angular#56300 Closes: angular#27786
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Jun 6, 2024
This commit addresses an issue where the `@angular/localize/init` polyfill is not included when there are no polyfills specified in the `angular.json` file. However, this approach has a drawback: the localize polyfill will always be added if it is found in a monorepo, even if an application does not use i18n. As a result, we will issue a warning to inform users about this behavior and encourage them to explicitly add it to their `polyfills` configuration. The `ng add` schematic will also be updated to add the polyfill as in the builders config, see: angular/angular#56300 Closes: angular#27786
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@alan-agius4 looks great, I've just added a couple minor comments.
b3e0c88 to
9742b21
Compare
9742b21 to
bfdcf4a
Compare
clydin
approved these changes
Jun 6, 2024
Member
|
This PR was merged into the repository by commit 81486c2. |
cexbrayat
added a commit
to cexbrayat/angular-cli
that referenced
this pull request
Jul 1, 2024
It can be re-enabled now that angular/angular#56300 have been released in v18.1.0-next.2
13 tasks
cexbrayat
added a commit
to cexbrayat/angular-cli
that referenced
this pull request
Jul 1, 2024
It can be re-enabled now that angular/angular#56300 have been released in v18.1.0-next.2
cexbrayat
added a commit
to cexbrayat/angular-cli
that referenced
this pull request
Jul 1, 2024
It can be re-enabled now that angular/angular#56300 have been released in v18.1.0-next.2
cexbrayat
added a commit
to cexbrayat/angular-cli
that referenced
this pull request
Jul 1, 2024
It can be re-enabled now that angular/angular#56300 have been released in v18.1.0-next.2
clydin
pushed a commit
to angular/angular-cli
that referenced
this pull request
Jul 1, 2024
It can be re-enabled now that angular/angular#56300 have been released in v18.1.0-next.2
clydin
pushed a commit
to angular/angular-cli
that referenced
this pull request
Jul 1, 2024
It can be re-enabled now that angular/angular#56300 have been released in v18.1.0-next.2 (cherry picked from commit 355ae1a)
This was referenced Jul 4, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue where the
@angular/localize/initpolyfill is not included when there are no polyfills specified in theangular.jsonfile.