feat(compiler): Add extended diagnostic to warn when there are uncall… #56295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
reviewed
Jun 6, 2024
JeanMeche
reviewed
Jun 6, 2024
...compiler-cli/src/ngtsc/typecheck/extended/checks/uncalled_function_in_event_binding/index.ts
Outdated
Show resolved
Hide resolved
7984b73 to
96f8cf7
Compare
4ab103e to
5f29588
Compare
devversion
reviewed
Jun 13, 2024
...ompiler-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_event_binding/index.ts
Outdated
Show resolved
Hide resolved
...ompiler-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_event_binding/index.ts
Outdated
Show resolved
Hide resolved
...ompiler-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_event_binding/index.ts
Outdated
Show resolved
Hide resolved
...ompiler-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_event_binding/index.ts
Outdated
Show resolved
Hide resolved
b71b2ff to
a05d143
Compare
a05d143 to
f7871a3
Compare
f7871a3 to
8adf83a
Compare
thePunderWoman
approved these changes
Jun 18, 2024
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
Thanks for this!
reviewed-for: public-api
JoostK
reviewed
Jun 26, 2024
Member
JoostK
left a comment
There was a problem hiding this comment.
This needs a documentation page!
...ompiler-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_event_binding/index.ts
Outdated
Show resolved
Hide resolved
...ompiler-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_event_binding/index.ts
Outdated
Show resolved
Hide resolved
8adf83a to
1fb4811
Compare
1fff002 to
86bf4cf
Compare
Contributor
Author
Done |
thePunderWoman
approved these changes
Jul 3, 2024
Contributor
|
This PR was merged into the repository by commit c8e2885. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed functions in event bindings
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #56293
What is the new behavior?
Does this PR introduce a breaking change?
Other information