fix(core): Fix shouldPreventDefaultBeforeDispatching bug #56188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I copied this over in angular@caedd10 the parentheses moved around the A tag check and the CLICK type check, instead of around the CLICK and CLICKMOD check.
AndrewKushnir
approved these changes
May 30, 2024
Contributor
Author
|
TESTED=Bypassing TGP due to urgent bugfix. |
thePunderWoman
approved these changes
May 30, 2024
mturco
approved these changes
May 30, 2024
Contributor
mturco
left a comment
There was a problem hiding this comment.
Reviewed-for: primitives-shared
iteriani
approved these changes
May 30, 2024
thePunderWoman
pushed a commit
that referenced
this pull request
May 30, 2024
Contributor
|
This PR was merged into the repository by commit b6fb53c. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I copied this over in caedd10 the parentheses moved around the A tag check and the CLICK type check, instead of around the CLICK and CLICKMOD check.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?