Skip to content

fix(migrations): do not generate aliased variables with the same name #56154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crisbeto wants to merge 1 commit into from
Closed

fix(migrations): do not generate aliased variables with the same name #56154

crisbeto wants to merge 1 commit into from

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented May 29, 2024

Adds some logic to avoid generating expressions like let $index = $index in the control flow migration.

Fixes #56152.

@crisbeto
fix(migrations): do not generate aliased variables with the same name
f365727 
Adds some logic to avoid generating expressions like `let $index = $index` in the control flow migration.

Fixes angular#56152.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels May 29, 2024
@crisbeto crisbeto requested a review from thePunderWoman May 29, 2024 12:41
@pkozlowski-opensource pkozlowski-opensource added the area: migrations Issues related to `ng update`/`ng generate` migrations label May 29, 2024
@ngbot ngbot bot added this to the Backlog milestone May 29, 2024
thePunderWoman
thePunderWoman approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 29, 2024
thePunderWoman pushed a commit that referenced this pull request May 30, 2024
@crisbeto @thePunderWoman
fix(migrations): do not generate aliased variables with the same name (…
b70b80b 
…#56154)

Adds some logic to avoid generating expressions like `let $index = $index` in the control flow migration.

Fixes #56152.

PR Close #56154
@thePunderWoman
Copy link
Contributor

thePunderWoman commented May 30, 2024

This PR was merged into the repository by commit 75e811c.

@sixcorners sixcorners mentioned this pull request Jun 27, 2024
Closed
@ambrose40 ambrose40 mentioned this pull request Jun 27, 2024
Open
@Rosenstein Rosenstein mentioned this pull request Jun 28, 2024
Merged
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 30, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

control-flow migration creates $index variable that will not compile in Angular 18

3 participants

@crisbeto @thePunderWoman @pkozlowski-opensource