Skip to content

fix(core): link errors to ADEV #56038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pkozlowski-opensource wants to merge 1 commit into from
Closed

fix(core): link errors to ADEV #56038

pkozlowski-opensource wants to merge 1 commit into from

Conversation

@pkozlowski-opensource
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented May 23, 2024

This is part of #55554 targeting the main branch. The commit in question was reverted in main since it requires a G3 patch cleanup.

@JeanMeche @pkozlowski-opensource
fix(core): link errors to ADEV (angular#55554)
7ba050f 
Console error links will now point to adev.

PR Close angular#55554
@pullapprove pullapprove bot requested review from AndrewKushnir and atscott May 23, 2024 12:06
@pkozlowski-opensource
Copy link
Member Author

pkozlowski-opensource commented May 23, 2024

@JeanMeche FYI

@pkozlowski-opensource pkozlowski-opensource added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 23, 2024
@pkozlowski-opensource
Copy link
Member Author

pkozlowski-opensource commented May 23, 2024

caretaker note: this will require patch update from https://critique.corp.google.com/cl/636499042 before landing.

@pkozlowski-opensource pkozlowski-opensource added the area: core Issues related to the framework runtime label May 23, 2024
@ngbot ngbot bot added this to the Backlog milestone May 23, 2024
@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 23, 2024
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request May 23, 2024
Closed
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 28, 2024
@pkozlowski-opensource
Copy link
Member Author

pkozlowski-opensource commented May 28, 2024

This PR was merged into the repository by commit b2445a0.

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 28, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@pkozlowski-opensource @atscott @AndrewKushnir @JeanMeche