Skip to content

Template syntax diagnostics in local compilation mode #55855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pmvald wants to merge 1 commit into from
Closed

Template syntax diagnostics in local compilation mode #55855

pmvald wants to merge 1 commit into from

Conversation

@pmvald
Copy link
Member

@pmvald pmvald commented May 17, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pmvald pmvald force-pushed the lcm-template-errors branch 2 times, most recently from 7dcc2c2 to 382d8d9 Compare May 26, 2024 19:41
@pmvald pmvald changed the title wip lcm template Template syntax diagnostics in local compilation mode May 26, 2024
@pmvald pmvald added action: review The PR is still awaiting reviews from at least one requested reviewer area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release labels May 26, 2024
@ngbot ngbot bot added this to the Backlog milestone May 26, 2024
@pmvald pmvald requested a review from devversion May 26, 2024 19:46
@pmvald pmvald marked this pull request as ready for review May 26, 2024 19:47
devversion
devversion approved these changes May 27, 2024
View reviewed changes
@pmvald
fix(compiler-cli): Show template syntax errors in local compilation m…
8e2b916 
…odified

Currently the template syntax errors are extracted in the template type check phase. But in local compilation mode we skip the type check phase. As a result template syntax errors are not displayed. With this change we show the template syntax diagnostics in local mode.
@pmvald pmvald force-pushed the lcm-template-errors branch from 382d8d9 to 8e2b916 Compare May 29, 2024 19:56
@pmvald pmvald added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 31, 2024
@thePunderWoman
Copy link
Contributor

thePunderWoman commented May 31, 2024

This PR was merged into the repository by commit 9e21582.

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 4, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@pmvald @thePunderWoman @devversion