Skip to content

fix(core): link errors to ADEV #55554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeanMeche wants to merge 1 commit into from
Closed

fix(core): link errors to ADEV #55554

JeanMeche wants to merge 1 commit into from

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Apr 25, 2024 •
edited
Loading

Console error links will now point to adev.

@pullapprove pullapprove bot requested a review from dylhunn April 25, 2024 23:12
AndrewKushnir
AndrewKushnir reviewed Apr 26, 2024
View reviewed changes
@JeanMeche JeanMeche force-pushed the core/error-links branch 2 times, most recently from 1ed3610 to 52aaac6 Compare April 26, 2024 23:37
@thePunderWoman thePunderWoman added the area: core Issues related to the framework runtime label Apr 30, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 30, 2024
@JeanMeche JeanMeche added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 4, 2024
@JeanMeche JeanMeche force-pushed the core/error-links branch 2 times, most recently from 95d8125 to 4e18058 Compare May 4, 2024 03:01
@JeanMeche JeanMeche mentioned this pull request May 7, 2024
Closed
@JeanMeche JeanMeche added the target: rc This PR is targeted for the next release-candidate label May 7, 2024
@JeanMeche
fix(core): link errors to ADEV
1347b7e 
Console error links will now point to adev.
@JeanMeche JeanMeche force-pushed the core/error-links branch from 4e18058 to 1347b7e Compare May 7, 2024 14:01
@JeanMeche JeanMeche changed the title refactor(core): link errors to ADEV fix(core): link errors to ADEV May 7, 2024
@AndrewKushnir AndrewKushnir removed the request for review from dylhunn May 7, 2024 15:14
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 7, 2024
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label May 16, 2024
@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels May 22, 2024
@JeanMeche JeanMeche mentioned this pull request May 23, 2024
Closed
14 tasks
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented May 23, 2024

This PR was merged into the repository by commit dd0700f.

pkozlowski-opensource pushed a commit that referenced this pull request May 23, 2024
@JeanMeche @pkozlowski-opensource
fix(core): link errors to ADEV (#55554)
d73a017 
Console error links will now point to adev.

PR Close #55554
@JeanMeche JeanMeche deleted the core/error-links branch May 23, 2024 09:59
pkozlowski-opensource added a commit to pkozlowski-opensource/angular that referenced this pull request May 23, 2024
@pkozlowski-opensource
Revert "fix(core): link errors to ADEV (angular#55554)"
816ac39 
This reverts commit dd0700f.
We will need G3 patch cleanup before this one can land.
pkozlowski-opensource added a commit that referenced this pull request May 23, 2024
@pkozlowski-opensource
Revert "fix(core): link errors to ADEV (#55554)" (#56031)
760207b 
This reverts commit dd0700f.
We will need G3 patch cleanup before this one can land.

PR Close #56031
pkozlowski-opensource pushed a commit to pkozlowski-opensource/angular that referenced this pull request May 23, 2024
@JeanMeche @pkozlowski-opensource
fix(core): link errors to ADEV (angular#55554)
7ba050f 
Console error links will now point to adev.

PR Close angular#55554
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request May 23, 2024
Closed
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented May 23, 2024

This PR landed in 18.x branch, the main branch will be updated via #56038 (requires patch update in G3)

@JeanMeche JeanMeche mentioned this pull request May 23, 2024
Closed
pkozlowski-opensource pushed a commit that referenced this pull request May 28, 2024
@JeanMeche @pkozlowski-opensource
fix(core): link errors to ADEV (#55554) (#56038)
b2445a0 
Console error links will now point to adev.

PR Close #55554

PR Close #56038
@sixcorners sixcorners mentioned this pull request Jun 19, 2024
Closed
@ambrose40 ambrose40 mentioned this pull request Jun 20, 2024
Open
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 23, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub alxhub approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@JeanMeche @pkozlowski-opensource @alxhub @AndrewKushnir @thePunderWoman