fix(core): update `ApplicationRef.isStable` to account for rendering pending tasks #50425

alan-agius4 · 2023-05-23T14:23:41Z

fix(core): update ApplicationRef.isStable to account for rendering pending tasks

This commit updates the ApplicationRef.isStable API to account for pending rendering task. This is needed as once a pending rendering task is done, new macrotask and microtask could be created which previously caused these not to be intercepted and thus ignored when doing SSR.

refactor(http): replace zone.js macrotask creation with InitialRenderPendingTasks

This commits refactors the HTTP client to use InitialRenderPendingTasks instead of Zone.js macrotask. This is another approach to #50406 which was revert due to a failure in G3.

packages/platform-server/test/hydration_spec.ts

packages/common/http/src/transfer_cache.ts

AndrewKushnir

LGTM 👍

@alan-agius4 my original thinking was that we wanted to do the inverse though: use the InitialRenderPendingTasks as the main instance that controls the state and make ApplicationRef.isStable contribute to it. However, in this case the InitialRenderPendingTasks needs to be an observable too. Let's ship the fix as is and come back to this discussion later (as a part of zoneless support for SSR).

…pending tasks This commit updates the `ApplicationRef.isStable` API to account for pending rendering task. This is needed as once a pending rendering task is done, new macrotask and microtask could be created which previously caused these not to be intercepted and thus ignored when doing SSR.

…dering pending tasks

goldens/size-tracking/integration-payloads.json

alan-agius4 · 2023-05-27T12:05:50Z

Caretaker note: G3 failures are pre-existing.

AndrewKushnir

Reviewed-for: size-tracking

AndrewKushnir · 2023-05-27T18:27:51Z

@alan-agius4 I've LGTM'ed for size-tracking, is it ready for merge?

alan-agius4 · 2023-05-27T18:53:20Z

Yes @AndrewKushnir

dylhunn · 2023-05-30T19:58:26Z

This PR was merged into the repository by commit 0c80349.

…pending tasks (#50425) This commit updates the `ApplicationRef.isStable` API to account for pending rendering task. This is needed as once a pending rendering task is done, new macrotask and microtask could be created which previously caused these not to be intercepted and thus ignored when doing SSR. PR Close #50425

…rPendingTasks` (#50425) This commits refactors the HTTP client to use `InitialRenderPendingTasks` instead of Zone.js macrotask. This is another approach to #50406 which was revert due to a failure in G3. PR Close #50425

matthew-whitfield-uk · 2023-06-02T16:03:19Z

From my tests, this seems to re-introduce the bug fixed originally in #50406 (issue - #50405)

The HTML rendered on the server side by angular universal doesn't wait for HTTP calls to complete before sending the HTML to the user.

Here is a minimal repo - https://github.com/matthew-whitfield-uk/transfer-state-demo

Steps:

npm run dev:ssr to start universal server
navigate to /test-page route
view the console to see that HTTP request is not transferred to client, only a state set on initialisation is transferred

alan-agius4 · 2023-06-05T09:24:12Z

@matthew-whitfield-uk, please subscribe to #50562

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fanimations/16.0.2/16.0.4) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcommon/16.0.2/16.0.4) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/16.0.2/16.0.4) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/16.0.2/16.0.4) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcore/16.0.2/16.0.4) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fforms/16.0.2/16.0.4) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/16.0.2/16.0.4) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`16.0.2` -> `16.0.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/16.0.2/16.0.4) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v16.0.4`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1604-2023-06-01) [Compare Source](angular/angular@16.0.3...16.0.4) ##### animations | Commit | Type | Description | | -- | -- | -- | | [df65c4fc8f](angular/angular@df65c4f) | fix | Trigger leave animation when ViewContainerRef is injected ([#48705](angular/angular#48705)) | ##### common | Commit | Type | Description | | -- | -- | -- | | [7e1bc513de](angular/angular@7e1bc51) | fix | untrack subscription and unsubscription in async pipe ([#50522](angular/angular#50522)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [9970b29ace](angular/angular@9970b29) | fix | update `ApplicationRef.isStable` to account for rendering pending tasks ([#50425](angular/angular#50425)) |  ### [`v16.0.3`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1603-2023-05-24) [Compare Source](angular/angular@16.0.2...16.0.3) ##### core | Commit | Type | Description | | -- | -- | -- | | [c11041e372](angular/angular@c11041e) | fix | adds missing symbols for animation standalone bundling test ([#50434](angular/angular#50434)) | | [98e8fdf40e](angular/angular@98e8fdf) | fix | fix `Self` flag inside embedded views with custom injectors ([#50270](angular/angular#50270)) | | [199ff4fe7f](angular/angular@199ff4f) | fix | host directives incorrectly validating aliased bindings ([#50364](angular/angular#50364)) | ##### http | Commit | Type | Description | | -- | -- | -- | | [080bbd2137](angular/angular@080bbd2) | fix | create macrotask during request handling instead of load start ([#50406](angular/angular#50406)) |  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1915 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2023-07-06T00:10:20Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…pending tasks (angular#50425) This commit updates the `ApplicationRef.isStable` API to account for pending rendering task. This is needed as once a pending rendering task is done, new macrotask and microtask could be created which previously caused these not to be intercepted and thus ignored when doing SSR. PR Close angular#50425

…rPendingTasks` (angular#50425) This commits refactors the HTTP client to use `InitialRenderPendingTasks` instead of Zone.js macrotask. This is another approach to angular#50406 which was revert due to a failure in G3. PR Close angular#50425

alan-agius4 self-assigned this May 23, 2023

alan-agius4 force-pushed the pending-tasks branch from a77ea3a to 12bd8bc Compare May 23, 2023 14:24

alfaproject reviewed May 24, 2023

View reviewed changes

packages/platform-server/test/hydration_spec.ts Outdated Show resolved Hide resolved

alan-agius4 added area: core Issues related to the framework runtime area: server Issues related to server-side rendering target: patch This PR is targeted for the next patch release core: hydration labels May 25, 2023

ngbot bot modified the milestone: Backlog May 25, 2023

alan-agius4 added the area: common/http Issues related to HTTP and HTTP Client label May 25, 2023

alan-agius4 force-pushed the pending-tasks branch from 12bd8bc to 93324f0 Compare May 25, 2023 09:31

alfaproject reviewed May 25, 2023

View reviewed changes

packages/common/http/src/transfer_cache.ts Outdated Show resolved Hide resolved

alan-agius4 force-pushed the pending-tasks branch from 93324f0 to eb29609 Compare May 25, 2023 10:17

alan-agius4 removed the area: common/http Issues related to HTTP and HTTP Client label May 25, 2023

alan-agius4 force-pushed the pending-tasks branch from eb29609 to 9300ed4 Compare May 25, 2023 10:39

alan-agius4 marked this pull request as ready for review May 25, 2023 12:12

pullapprove bot requested review from crisbeto and dylhunn May 25, 2023 12:12

alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 25, 2023

alan-agius4 requested review from AndrewKushnir and removed request for crisbeto May 25, 2023 12:13

alan-agius4 mentioned this pull request May 25, 2023

[BUG]: Using Zone.current.scheduleMacroTask doesn't delay serialization during SSR in v16 #50414

Closed

AndrewKushnir previously approved these changes May 26, 2023

View reviewed changes

AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 26, 2023

alan-agius4 removed the request for review from dylhunn May 26, 2023 04:15

alan-agius4 force-pushed the pending-tasks branch from 9300ed4 to dc62605 Compare May 26, 2023 10:21

alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 26, 2023

alan-agius4 requested a review from AndrewKushnir May 26, 2023 12:02

fixup! fix(core): update ApplicationRef.isStable to account for ren…

39d9334

…dering pending tasks

pullapprove bot requested review from AndrewKushnir and dylhunn May 27, 2023 11:58

alan-agius4 commented May 27, 2023

View reviewed changes

goldens/size-tracking/integration-payloads.json Show resolved Hide resolved

alan-agius4 added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: global presubmit The PR is in need of a google3 global presubmit labels May 27, 2023

AndrewKushnir approved these changes May 27, 2023

View reviewed changes

AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 27, 2023

alan-agius4 removed the request for review from dylhunn May 27, 2023 18:53

alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 27, 2023

alan-agius4 added the area: common/http Issues related to HTTP and HTTP Client label May 27, 2023

dylhunn closed this in 28c68f7 May 30, 2023

alan-agius4 deleted the pending-tasks branch May 30, 2023 20:00

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(core): update `ApplicationRef.isStable` to account for rendering pending tasks #50425

fix(core): update `ApplicationRef.isStable` to account for rendering pending tasks #50425

Uh oh!

alan-agius4 commented May 23, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

AndrewKushnir left a comment

Uh oh!

Uh oh!

alan-agius4 commented May 27, 2023

Uh oh!

AndrewKushnir left a comment

Uh oh!

AndrewKushnir commented May 27, 2023

Uh oh!

alan-agius4 commented May 27, 2023

Uh oh!

dylhunn commented May 30, 2023

Uh oh!

matthew-whitfield-uk commented Jun 2, 2023

Uh oh!

alan-agius4 commented Jun 5, 2023

Uh oh!

angular-automatic-lock-bot bot commented Jul 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix(core): update ApplicationRef.isStable to account for rendering pending tasks #50425

fix(core): update ApplicationRef.isStable to account for rendering pending tasks #50425

Uh oh!

Conversation

alan-agius4 commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alan-agius4 commented May 27, 2023

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir commented May 27, 2023

Uh oh!

alan-agius4 commented May 27, 2023

Uh oh!

dylhunn commented May 30, 2023

Uh oh!

matthew-whitfield-uk commented Jun 2, 2023

Uh oh!

alan-agius4 commented Jun 5, 2023

Uh oh!

angular-automatic-lock-bot bot commented Jul 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix(core): update `ApplicationRef.isStable` to account for rendering pending tasks #50425

fix(core): update `ApplicationRef.isStable` to account for rendering pending tasks #50425

alan-agius4 commented May 23, 2023 •

edited

Loading