Skip to content

fix(http): HTTP cache was being disabled prematurely #49826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alan-agius4 wants to merge 1 commit into from
Closed

fix(http): HTTP cache was being disabled prematurely #49826

alan-agius4 wants to merge 1 commit into from

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Apr 13, 2023

This commit fixes an issue were on the server the HTTP cache was being disabled prematurely which caused HTTP calls performed in ngOnInit life cycle hooks not to be cached.

@alan-agius4
fix(http): HTTP cache was being disabled prematurely
1e99101 
This commit fixes an issue were on the server the HTTP cache was being disabled prematurely which caused HTTP calls performed in `ngOnInit` life cycle hooks not to be cached.
@pullapprove pullapprove bot requested a review from jessicajaniuk April 13, 2023 07:21
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate area: common/http Issues related to HTTP and HTTP Client labels Apr 13, 2023
@ngbot ngbot bot added this to the Backlog milestone Apr 13, 2023
@jessicajaniuk jessicajaniuk removed the request for review from AndrewKushnir April 13, 2023 13:39
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 13, 2023
@jessicajaniuk
Copy link
Contributor

jessicajaniuk commented Apr 13, 2023

This PR was merged into the repository by commit ddf0d4e.

jessicajaniuk pushed a commit that referenced this pull request Apr 13, 2023
@alan-agius4 @thePunderWoman
fix(http): HTTP cache was being disabled prematurely (#49826)
2a580b6 
This commit fixes an issue were on the server the HTTP cache was being disabled prematurely which caused HTTP calls performed in `ngOnInit` life cycle hooks not to be cached.

PR Close #49826
@alan-agius4 alan-agius4 deleted the http-cache-ngoninit branch April 13, 2023 16:08
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 14, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-agius4 @jessicajaniuk