Skip to content

Conversation

@pkozlowski-opensource
Copy link
Member

This change exposes the onDestroy callback on the ApplicationRef as the public API. It is useful for cases where people need to execute cleanup logic on application teardown.

Closes #49087

This change exposes the onDestroy callback on the ApplicationRef
as the public API. It is useful for cases where people need to
execute cleanup logic on application teardown.

Closes angular#49087
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 3, 2023
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review April 3, 2023 09:06
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Apr 3, 2023
@ngbot ngbot bot modified the milestone: Backlog Apr 3, 2023
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: fw-core, public-api

@pullapprove pullapprove bot requested a review from dylhunn April 3, 2023 14:03
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 3, 2023
@AndrewKushnir AndrewKushnir removed the request for review from dylhunn April 3, 2023 18:48
@pkozlowski-opensource pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Apr 3, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Apr 3, 2023

This PR was merged into the repository by commit a5f1737.

@dylhunn dylhunn closed this in a5f1737 Apr 3, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ApplicationRef's onDestroy method should not be internal

5 participants