Skip to content

fix(platform-browser): set nonce attribute in a platform compatible way #49624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alan-agius4 wants to merge 2 commits into from
Closed

fix(platform-browser): set nonce attribute in a platform compatible way #49624

alan-agius4 wants to merge 2 commits into from

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Mar 29, 2023 •
edited
Loading

Setting the nonce attribute using the property is not supported by Domino. This change update the usage to use setAttribute and also add a test to verify that the nonce is set when it should.

//cc @crisbeto

@pullapprove pullapprove bot requested a review from jessicajaniuk March 29, 2023 08:28
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime labels Mar 29, 2023
@ngbot ngbot bot added this to the Backlog milestone Mar 29, 2023
@alan-agius4
fix(platform-browser): set nonce attribute in a platform compatible way
74cd7a8 
Setting the `nonce` attribute using the property is not supported by Domino. This change update the usage to use `setAttribute` and also add a test to verify that the `nonce` is set when it should.
@alan-agius4 alan-agius4 requested review from atscott and removed request for jessicajaniuk March 29, 2023 15:10
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 29, 2023
@AndrewKushnir AndrewKushnir removed the request for review from atscott March 29, 2023 15:15
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 29, 2023
@atscott
Copy link
Contributor

atscott commented Mar 29, 2023

This PR was merged into the repository by commit e8e3681.

@atscott atscott closed this in e8e3681 Mar 29, 2023
@alan-agius4 alan-agius4 deleted the nonce-fix-server branch March 29, 2023 17:25
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 29, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: stylesheets target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@alan-agius4 @atscott @crisbeto @AndrewKushnir