feat(core): allow removal of previously registered DestroyRef callbacks #49493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d33118a to
897758c
Compare
alxhub
approved these changes
Mar 20, 2023
atscott
approved these changes
Mar 20, 2023
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api, size-tracking
91de568 to
3d38f02
Compare
AndrewKushnir
approved these changes
Mar 20, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
LGTM 👍 Just left a few minor comments, but none of them are blocking.
jessicajaniuk
approved these changes
Mar 20, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
828a369 to
382cd04
Compare
d7379c3 to
716635c
Compare
This change makes it possible to remove a previously registered destroy callback - to do so it is enough to call the unregistration function returned from the onDestroy method call.
716635c to
e52ca40
Compare
Member
Author
|
This PR was merged into the repository by commit d1617c4. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to remove a previously registered destroy callback - to do so it is enough to call the unregistration function returned from the onDestroy method call.