feat(core): remove entryComponents #49484
Conversation
b514623 to
59dda69
Compare
|
Caretaker note: cl/517941577 will have to be patched in together with this change in order to avoid breakages in g3. Copybara will have to be re-run after the change is patched so that the changes are reflected in the CL. |
aio/content/guide/deprecations.md
Outdated
There was a problem hiding this comment.
Is it conscious choice to have kept the entry and the section about the entryComponents & ANALYZE_FOR_ENTRY_COMPONENTS ?
There was a problem hiding this comment.
Yes, I wanted to keep the reference in case folks see an error don't know where it's coming from.
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
`entryComponents` have been deprecated since version 9, because with Ivy they weren't necessary. These changes remove any remaining references. BREAKING CHANGE: * `entryComponents` has been deleted from the `@NgModule` and `@Component` public APIs. Any usages can be removed since they weren't doing anyting. * `ANALYZE_FOR_ENTRY_COMPONENTS` injection token has been deleted. Any references can be removed.
59dda69 to
5b1ea03
Compare
|
This PR was merged into the repository by commit 585e34b. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
entryComponentshave been deprecated since version 9, because with Ivy they weren't necessary. These changes remove any remaining references.BREAKING CHANGE:
entryComponentshas been deleted from the@NgModuleand@Componentpublic APIs. Any usages can be removed since they weren't doing anyting.ANALYZE_FOR_ENTRY_COMPONENTSinjection token has been deleted. Any references can be removed.