Skip to content

fix(platform-browser): only add ng-app-id to style on server side #49465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alan-agius4 wants to merge 2 commits into from
Closed

fix(platform-browser): only add ng-app-id to style on server side #49465

alan-agius4 wants to merge 2 commits into from

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Mar 17, 2023

This commit fixes an issue where it causes issues in G3 when we add ng-app-id on browser apps.

@alan-agius4
fix(platform-browser): only add ng-app-id to style on server side
165f80a 
This commit fixes an issue where it causes issues in G3 when we add `ng-app-id` on browser apps.
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Mar 17, 2023
@pkozlowski-opensource pkozlowski-opensource added the area: core Issues related to the framework runtime label Mar 17, 2023
@ngbot ngbot bot added this to the Backlog milestone Mar 17, 2023
pkozlowski-opensource
pkozlowski-opensource approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: size-tracking

jessicajaniuk
jessicajaniuk approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: size-tracking

@alan-agius4
Copy link
Contributor Author

alan-agius4 commented Mar 17, 2023 •
edited
Loading

Presubmit http://test/OCL:517425516:BASE:517425563:1679068763282:970150dc

@alan-agius4 alan-agius4 removed the request for review from alxhub March 17, 2023 16:15
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 17, 2023
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Mar 17, 2023

This PR was merged into the repository by commit c934a8e.

@alan-agius4 alan-agius4 deleted the fix-attr branch March 17, 2023 16:27
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 17, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

+1 more reviewer

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@alan-agius4 @pkozlowski-opensource @AndrewKushnir @jessicajaniuk