Skip to content

Conversation

@alan-agius4
Copy link
Contributor

This commit adds the provideServerSupport() function that returns the EnvironmentProviders needed to setup server rendering without NgModules.

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer area: server Issues related to server-side rendering target: minor This PR is targeted for the next minor release labels Mar 9, 2023
@ngbot ngbot bot modified the milestone: Backlog Mar 9, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Mar 9, 2023
… server capabilities to an application

This commit adds the `provideServerSupport()` function that returns the `EnvironmentProviders` needed to setup server rendering without NgModules.
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-platform-server, public-api

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-agius4 I think it'd be great to avoid the usage of importProvidersFrom and just use the functions that return providers directly.

We could also update the renderApplication providers here to use the new method and replace BrowserModule.withServerTransition with an APP_ID provider. WDYT?

importProvidersFrom(BrowserModule.withServerTransition({appId})),
importProvidersFrom(ServerModule),

@pullapprove pullapprove bot requested a review from AndrewKushnir March 9, 2023 17:43
…provide server capabilities to an application
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pullapprove pullapprove bot requested a review from AndrewKushnir March 10, 2023 17:13
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 10, 2023
@jessicajaniuk jessicajaniuk added the action: merge The PR is ready for merge by the caretaker label Mar 10, 2023
@alxhub
Copy link
Member

alxhub commented Mar 14, 2023

This PR was merged into the repository by commit 056d680.

@alxhub alxhub closed this in 056d680 Mar 14, 2023
@alan-agius4 alan-agius4 deleted the server-support branch March 14, 2023 16:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: server Issues related to server-side rendering detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants