fix(platform-browser):KeyEventsPlugin should keep the same behavior #49330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close angular#45698 KeyEventsPlugin now has different behavior with EventsPlugin, it will always run inside ngZone with ngZone.runGuarded() no matter the component is initialized inside or outside of NgZone, this PR make sure KeyEventsPlugin bahave the same with other events.
Contributor
|
This PR was merged into the repository by commit 2312eb5. |
Contributor
|
This has caused a test breakage in Google3. I'll revert this, and we'll have to run a TGP to see if this can land safely. |
jessicajaniuk
pushed a commit
to jessicajaniuk/angular
that referenced
this pull request
Mar 7, 2023
…ehavior (angular#49330)" This reverts commit 2312eb5.
jessicajaniuk
pushed a commit
that referenced
this pull request
Mar 7, 2023
Contributor
Author
|
Got it, Thank you @jessicajaniuk |
Contributor
Contributor
|
There are definitely some failing tests, but the amount is very small. I'll see if I can address them in the next week so this can land. |
Contributor
Author
|
Thank you @jessicajaniuk, if there are anything I can do, please let me know. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #45698
KeyEventsPlugin now has different behavior with EventsPlugin, it will always run inside ngZone with ngZone.runGuarded() no matter the component is initialized inside or outside of NgZone, this PR make sure KeyEventsPlugin bahave the same with other events.