Skip to content

Conversation

@alan-agius4
Copy link
Contributor

feat(core): add mergeApplicationConfig method

This commits add a utility method to merge multiple ApplicationConfiguration into one from left to right. This is useful for server rendering were an application might have several configurations.

Usage Example:

const config = mergeApplicationConfig(appConfig, appServerConfig);

refactor(platform-browser): move ApplicationConfig to core

This is needed to provide the merge configuration method which will reside in core.

DEPRECATED: ApplicationConfig has moved, please import ApplicationConfig from @angular/core instead.

This is needed to provide the merge configuration method which will reside in core.

DEPRECATED: `ApplicationConfig` has moved, please import `ApplicationConfig` from `@angular/core` instead.
This commits add a utility method to merge multiple `ApplicationConfiguration` into one from left to right.  This is useful for server rendering were an application might have several configurations.

Usage Example:
```ts
const config = mergeApplicationConfig(appConfig, appServerConfig);
```
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime labels Feb 28, 2023
@angular-robot angular-robot bot added the detected: deprecation PR contains a commit with a deprecation label Feb 28, 2023
@ngbot ngbot bot modified the milestone: Backlog Feb 28, 2023
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Feb 28, 2023
@alan-agius4 alan-agius4 requested review from AndrewKushnir and removed request for pkozlowski-opensource February 28, 2023 12:51
@alan-agius4 alan-agius4 changed the title feat(core): add mergeApplicationConfig method feat(core): add mergeApplicationConfig method Feb 28, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Feb 28, 2023
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from atscott February 28, 2023 18:55
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 28, 2023
@angular angular deleted a comment from ngbot bot Mar 1, 2023
@alan-agius4 alan-agius4 added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Mar 1, 2023
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 4e9531f.

AndrewKushnir pushed a commit that referenced this pull request Mar 1, 2023
This commits add a utility method to merge multiple `ApplicationConfiguration` into one from left to right.  This is useful for server rendering were an application might have several configurations.

Usage Example:
```ts
const config = mergeApplicationConfig(appConfig, appServerConfig);
```

PR Close #49253
@alan-agius4 alan-agius4 deleted the app-config-merge branch March 1, 2023 19:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: deprecation PR contains a commit with a deprecation detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants