refactor(common): remove deprecated XhrFactory export from http entrypoint
#49251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
nit: You can remove the entries in the depreciation guide |
…ntrypoint The deprecated `XhrFactory` export from `@angular/common/http` has been removed. BREAKING CHANGE: Deprecated `XhrFactory` export from `@angular/common/http` has been removed. Use `XhrFactory` from `@angular/common` instead.
43b5cc2 to
0d2108d
Compare
AndrewKushnir
approved these changes
Feb 28, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Looks great 👍
I didn't find any instances of that symbol (from @angular/common/http) in g3, but would be good to run a TGP just in case.
AndrewKushnir
approved these changes
Feb 28, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
dylhunn
approved these changes
Feb 28, 2023
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
Author
|
Global presubmit: http://test/OCL:512889239:BASE:513154502:1677658513854:fb8c3fba |
Contributor
|
This PR was merged into the repository by commit c41a216. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecated
XhrFactoryexport from@angular/common/httphas been removed.BREAKING CHANGE:
Deprecated
XhrFactoryexport from@angular/common/httphas been removed. UseXhrFactoryfrom@angular/commoninstead.