refactor(server): remove deprecated renderModuleFactory
#49247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ff3a90 to
225c1c2
Compare
The deprecated `renderModuleFactory` has been removed as it is no longer necessary with Ivy. BREAKING CHANGE: `renderModuleFactory` has been removed. Use `renderModule` instead.
225c1c2 to
cf9879a
Compare
AndrewKushnir
approved these changes
Feb 28, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@alan-agius4 thanks for the cleanup 👍
A couple quick comments:
- We can also update an error message here to exclude "[Factory]".
- There is one instance where
renderModuleFactoryis referenced in g3 code which we may need to cleanup before landing this change (just search forrenderModuleFactory).
Thank you.
AndrewKushnir
approved these changes
Feb 28, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
Contributor
Author
|
As discussed on slack, the G3 reference is not a problem as it’s an integration test of a NPM package which is not run in G3. |
jessicajaniuk
approved these changes
Feb 28, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api, fw-platform-server
Contributor
|
This PR was merged into the repository by commit 17abe6d. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecated
renderModuleFactoryhas been removed as it is no longer necessary with Ivy.BREAKING CHANGE:
renderModuleFactoryhas been removed. UserenderModuleinstead.//CC @AndrewKushnir