Conversation
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
| - name: Tag release | ||
| run: | | ||
| git tag ${{ github.event.inputs.version }} | ||
| git config --global user.name "anchoreci" |
Contributor
There was a problem hiding this comment.
Why pass --global? Is this setting correct for every job that runs on this CI worker? (Maybe it is, come to think of it.)
Contributor
Author
There was a problem hiding this comment.
I can leave off global and it would also still function (I added it out of habit), but leaving the global flag will not affect other jobs as the github hosted CI runners don't allow for persisted state (you get a clean state every time).
willmurphyscode
approved these changes
Sep 20, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the release pipeline to use annotated tags over lightweight tags and updates chronicle to the latest version to leverage this.
While looking at the old release logs I noticed that the cache keys are not unique, thus are causing cache restore errors (which file silently). Additionally I also removed an unused env var.