fix: duplicate entries in cyclonedx dependency list#2063
Merged
Conversation
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
spiffcs
approved these changes
Aug 25, 2023
This was referenced Aug 28, 2023
Closed
Merged
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Keith Zantow <kzantow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects an issue where Syft is not outputting CycloneDX dependencies properly -- instead of one entry for a unique
Ref, it was outputting multiple entries with the sameRef, which is not valid. The spec states: "All items must be unique", which seems to indicate each entry has a uniqueRefand thecyclonedx-cli validatefails.With this change, the latest
cyclonedx-cliindicates the BOM is now valid:Fixes: #2062