perf: avoid allocations with (*regexp.Regexp).MatchString#1592
Merged
spiffcs merged 1 commit intoanchore:mainfrom Nov 8, 2023
Juneezee:perf/regexp-matchstring
Merged
perf: avoid allocations with (*regexp.Regexp).MatchString#1592spiffcs merged 1 commit intoanchore:mainfrom Juneezee:perf/regexp-matchstring
(*regexp.Regexp).MatchString#1592spiffcs merged 1 commit intoanchore:mainfrom
Juneezee:perf/regexp-matchstring
Conversation
We should use `(*regexp.Regexp).MatchString` instead of
`(*regexp.Regexp).Match([]byte(...))` when matching string to avoid
unnecessary `[]byte` conversions and reduce allocations.
Example benchmark:
func BenchmarkMatch(b *testing.B) {
for i := 0; i < b.N; i++ {
if match := pseudoSemverPattern.Match([]byte("1.0.0-beta-prerelease")); !match {
b.Fail()
}
}
}
func BenchmarkMatchString(b *testing.B) {
for i := 0; i < b.N; i++ {
if match := pseudoSemverPattern.MatchString("1.0.0-beta-prerelease"); !match {
b.Fail()
}
}
}
goos: linux
goarch: amd64
pkg: github.com/anchore/grype/grype/version
cpu: AMD Ryzen 7 PRO 4750U with Radeon Graphics
BenchmarkMatch-16 1378789 889.7 ns/op 24 B/op 1 allocs/op
BenchmarkMatchString-16 2287442 482.2 ns/op 0 B/op 0 allocs/op
PASS
ok github.com/anchore/grype/grype/version 3.632s
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
spiffcs
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should use
(*regexp.Regexp).MatchStringinstead of(*regexp.Regexp).Match([]byte(...))when matching string to avoid unnecessary[]byteconversions and reduce allocations. A one-line change for free performance improvement.Example benchmark:
Result: