Conversation
3104b23 to
ef101d8
Compare
rcebulko
approved these changes
Sep 28, 2021
|
|
||
| // TODO: create better solution for parameterizing server tests. | ||
| test.serial('server=true: test Element.querySelectorAll on id selectors', (t) => { | ||
| process.env.SERVER = 'true'; |
Collaborator
There was a problem hiding this comment.
not sure what testing framework is in use, but maybe something like sandbox.stub(process.env, 'SERVER').value('true'); or something similar could do the trick.
Member
Author
There was a problem hiding this comment.
Will investigate this for a future PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup fix to a lil bug in #1096.
Note: the bug only affects server-lib.
Followup: need to come up with a good system for parameterizing tests