fix: error if CLI glob expansion fails

alecthomas · alecthomas · commit e1969ca85ebe · 2023-11-24T14:31:49.000+11:00
diff --git a/engine/engine.go b/engine/engine.go
@@ -394,11 +394,15 @@ func (e *Engine) Build(outputs []string) error {
 func (e *Engine) expandOutputs(outputs []string) ([]string, error) {
 	expanded := []string{}
 	for _, output := range outputs {
-		glob, err := e.normalisePath(output)
+		normalised, err := e.normalisePath(output)
 		if err != nil {
 			return nil, err
 		}
-		expanded = append(expanded, e.globber.MatchFilesystem(glob)...)
+		globbed := e.globber.MatchFilesystem(normalised)
+		if len(globbed) == 0 {
+			return nil, fmt.Errorf("no matching outputs for %q", normalised)
+		}
+		expanded = append(expanded, globbed...)
 	}
 	return expanded, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -394,11 +394,15 @@ func (e *Engine) Build(outputs []string) error {`
`394`	`394`	`func (e *Engine) expandOutputs(outputs []string) ([]string, error) {`
`395`	`395`	`expanded := []string{}`
`396`	`396`	`for _, output := range outputs {`
`397`		`- glob, err := e.normalisePath(output)`
	`397`	`+ normalised, err := e.normalisePath(output)`
`398`	`398`	`if err != nil {`
`399`	`399`	`return nil, err`
`400`	`400`	`}`
`401`		`- expanded = append(expanded, e.globber.MatchFilesystem(glob)...)`
	`401`	`+ globbed := e.globber.MatchFilesystem(normalised)`
	`402`	`+ if len(globbed) == 0 {`
	`403`	`+ return nil, fmt.Errorf("no matching outputs for %q", normalised)`
	`404`	`+ }`
	`405`	`+ expanded = append(expanded, globbed...)`
`402`	`406`	`}`
`403`	`407`	`return expanded, nil`
`404`	`408`	`}`