feat: glob-expand build/clean targets

alecthomas · alecthomas · commit 8fdbc63cbf70 · 2023-11-24T09:40:35.000+11:00
eg.

```
🐚 ~/dev/ftl $ bit -c 'build/release/*'
…/ftl-controller| $ rm -rf build/release/ftl-controller
…ease/ftl-runner| $ rm -rf build/release/ftl-runner
…ild/release/ftl| $ rm -rf build/release/ftl
…ease/ftl-initdb| $ rm -rf build/release/ftl-initdb
🐚 ~/dev/ftl $ bit 'build/release/*'
…ild/release/ftl| $ go build -o build/release/ftl -tags release -ldflags "-X main.version=v0.71.12-1-g611af4e -X main.timestamp=$(date +%s)" ./cmd/ftl
…/ftl-controller| $ go build -o build/release/ftl-controller -tags release -ldflags "-X main.version=v0.71.12-1-g611af4e -X main.timestamp=$(date +%s)" ./cmd/ftl-controller
…ease/ftl-initdb| $ go build -o build/release/ftl-initdb -tags release -ldflags "-X main.version=v0.71.12-1-g611af4e -X main.timestamp=$(date +%s)" ./cmd/ftl-initdb
…ease/ftl-runner| $ go build -o build/release/ftl-runner -tags release -ldflags "-X main.version=v0.71.12-1-g611af4e -X main.timestamp=$(date +%s)" ./cmd/ftl-runner
```
diff --git a/cmd/bit/main.go b/cmd/bit/main.go
@@ -31,7 +31,7 @@ type CLI struct {
 	List       bool               `short:"l" xor:"command" help:"List available targets."`
 	Describe   string             `short:"D" xor:"command" help:"Describe an aspect of the Bit build. ${describe_help}" required:"" enum:"files,deps,targets,ignored" placeholder:"ASPECT"`
 	Clean      bool               `short:"c" xor:"command" help:"Clean targets."`
-	Target     []string           `arg:"" optional:"" help:"Target to run."`
+	Target     []string           `arg:"" optional:"" help:"Targets to run (supports globbing)."`
 }
 
 const description = `
diff --git a/engine/engine.go b/engine/engine.go
@@ -320,6 +320,10 @@ func (e *Engine) setTargetCleanFunc(target *Target, directive *parser.Command) e
 }
 
 func (e *Engine) Clean(outputs []string) error {
+	outputs, err := e.expandOutputs(outputs)
+	if err != nil {
+		return err
+	}
 	outputsSet := map[string]bool{}
 	for _, output := range outputs {
 		outputsSet[output] = true
@@ -379,9 +383,26 @@ func (e *Engine) Close() error {
 }
 
 func (e *Engine) Build(outputs []string) error {
+	outputs, err := e.expandOutputs(outputs)
+	if err != nil {
+		return err
+	}
 	return e.build(outputs, map[string]bool{})
 }
 
+// Glob-expand outputs.
+func (e *Engine) expandOutputs(outputs []string) ([]string, error) {
+	expanded := []string{}
+	for _, output := range outputs {
+		glob, err := e.normalisePath(output)
+		if err != nil {
+			return nil, err
+		}
+		expanded = append(expanded, e.globber.MatchFilesystem(glob)...)
+	}
+	return expanded, nil
+}
+
 func (e *Engine) build(outputs []string, seen map[string]bool) error {
 	if len(outputs) == 0 {
 		outputs = e.Outputs()

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ type CLI struct {`
`31`	`31`	List bool `short:"l" xor:"command" help:"List available targets."`
`32`	`32`	Describe string `short:"D" xor:"command" help:"Describe an aspect of the Bit build. ${describe_help}" required:"" enum:"files,deps,targets,ignored" placeholder:"ASPECT"`
`33`	`33`	Clean bool `short:"c" xor:"command" help:"Clean targets."`
`34`		- Target []string `arg:"" optional:"" help:"Target to run."`
	`34`	+ Target []string `arg:"" optional:"" help:"Targets to run (supports globbing)."`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	const description = `