Remove REST API shims for code introduced in WP 4.9.8#8695
Merged
danielbachhuber merged 2 commits intomasterfrom Aug 7, 2018
Merged
Remove REST API shims for code introduced in WP 4.9.8#8695danielbachhuber merged 2 commits intomasterfrom
danielbachhuber merged 2 commits intomasterfrom
Conversation
Now that WP 4.9.8 is Gutenberg's minimum version, this is legacy code that can be removed.
tofumatt
approved these changes
Aug 7, 2018
Member
tofumatt
left a comment
There was a problem hiding this comment.
The rare and awesome all-red diff! 🎉
Makes sense to me. Go for the merge if Travis is green.
Member
Author
|
Deleted Travis build cache and restarted build. |
Member
Author
Ah, it was a valid failure 😄 |
Member
|
Nice :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that WP 4.9.8 is Gutenberg's minimum version, this is legacy code
that can be removed.
All existing tests remain in place and pass as expected.
Related #8454