Skip to content

Add inline comment that explains a stopPropagation()#8339

Merged
gziolo merged 1 commit intomasterfrom
add/inline-comment
Aug 1, 2018
Merged

Add inline comment that explains a stopPropagation()#8339
gziolo merged 1 commit intomasterfrom
add/inline-comment

Conversation

@noisysocks
Copy link
Copy Markdown
Member

Attempts to explain a call to event.stopPropagation() using an inline comment.

Fixes #6631 (comment).

@noisysocks noisysocks added the [Type] Code Quality Issues or PRs that relate to code quality label Jul 31, 2018
@noisysocks noisysocks requested a review from aduth July 31, 2018 23:32
Copy link
Copy Markdown
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gziolo gziolo added this to the 3.5 milestone Aug 1, 2018
@gziolo gziolo merged commit 7929c39 into master Aug 1, 2018
@gziolo gziolo deleted the add/inline-comment branch August 1, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants