Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Title attributes are not available to keyboard users, and may not be announced by screen readers depending on user settings. For more details please refer to https://core.trac.wordpress.org/ticket/24766
See also https://core.trac.wordpress.org/query?keywords=~title-attribute
This PR removes two title attributes used on the buttons in the Classic Editor warning introduced in #8247. As a best practice, it also adds a
type="button"attribute to a button. As said, the information in the title attributes is not available to all users and adds little to nothing to the info already provided via the button text."Edit in Gutenberg"
vs.
"Open this post in the Gutenberg block editor"
"Continue to Classic Editor"
vs.
"Close this dialog, and edit the post in the classic editor"
Fixes #8315