Add gutenberg_can_edit_post filter#8323
Merged
brandonpayton merged 2 commits intoWordPress:masterfrom Aug 8, 2018
Merged
Conversation
# Conflicts: # lib/register.php # phpunit/class-admin-test.php
4 tasks
brandonpayton
approved these changes
Aug 8, 2018
Member
brandonpayton
left a comment
There was a problem hiding this comment.
This looks good to me and is working well when tested locally.
It would be good for the tests to assert regarding the filter arguments, but apparently, that is somewhat awkward to do with PHP. I don't want to hold up this PR for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
gutenberg_can_edit_postfilter and additional unit tests.Fixes #5692
How has this been tested?
Added unit tests to ensure the
gutenberg_can_edit_postfilter returns true or false depending on the callback.Types of changes
New feature
Checklist: