Fix projectReferences with rootDir#871
Merged
andrewbranch merged 4 commits intoTypeStrong:masterfrom Nov 27, 2018
andrewbranch:bug/project-reference-root-dir
Merged
Fix projectReferences with rootDir#871andrewbranch merged 4 commits intoTypeStrong:masterfrom andrewbranch:bug/project-reference-root-dir
andrewbranch merged 4 commits intoTypeStrong:masterfrom
andrewbranch:bug/project-reference-root-dir
Conversation
…t JS file location
Contributor
Author
|
@johnnyreilly seeing one of those minor differences in source mapping metadata on the end of the file in CI... didn't we run into this at some point in #817? It looks familiar but I don't know what you did to fix it. |
Member
|
You rang? 😄 I've just deleted the I've pushed this - let's see how the CI gets on |
Member
|
Hey @andrewbranch, Are we good to merge and release this? Don't know if there's anything left to do? (I'm assuming not but I wanted to check) |
Contributor
Author
|
Release away! Thanks for the assist! |
Member
|
Released! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rootDirinside a referenced project’s config wasn’t being considered in figuring out where the output JS files for the project will be, a.k.a. why microsoft/TypeScript#26410 should still be a thing 🙂Fixes #868