docs(pagination): rephrase autoResetPageIndex behaviour#5601
Merged
KevinVandy merged 2 commits intoTanStack:mainfrom Jun 14, 2024
Merged
docs(pagination): rephrase autoResetPageIndex behaviour#5601KevinVandy merged 2 commits intoTanStack:mainfrom
KevinVandy merged 2 commits intoTanStack:mainfrom
Conversation
KevinVandy
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I was confused by the
autoResetPageIndexexplanation since I noticed it wasn't working on a table withmanualPagination(which is the expected behavior - all good here).The docs mention
autoResetPageIndexis true by default but I had a look at the code and if I'm not mistaken it is undefined by default.Here is when the magic happens:
table/packages/table-core/src/features/RowPagination.ts
Lines 226 to 230 in f7e69bc
I rephrased that sentence in the docs removing the mention to "the flag true by default". The behaviour is active by default, but the flag isn't true otherwise
manualPaginationwouldn't override it in the snippet above.