fix: getFacetedMinMaxValues default implementation sometimes returning array of arrays (#5676)

vincerubinetti · autofix-ci[bot] · KevinVandy · web-flow · commit 9d54b2e20f44 · 2024-08-03T15:47:46.000-05:00
* fix getFacetedMinMaxValues returning array bug

* rework for your consideration

* ci: apply automated fixes

* don't use array at

---------

Co-authored-by: autofix-ci[bot] &lt;114827586+autofix-ci[bot]@users.noreply.github.com&gt;
Co-authored-by: Kevin Van Cott &lt;kevinvandy656@gmail.com&gt;
diff --git a/packages/table-core/src/utils/getFacetedMinMaxValues.ts b/packages/table-core/src/utils/getFacetedMinMaxValues.ts
@@ -11,31 +11,22 @@ export function getFacetedMinMaxValues<TData extends RowData>(): (
       facetedRowModel => {
         if (!facetedRowModel) return undefined
 
-        const firstValue =
-          facetedRowModel.flatRows[0]?.getUniqueValues(columnId)
+        const uniqueValues = facetedRowModel.flatRows
+          .flatMap(flatRow => flatRow.getUniqueValues(columnId) ?? [])
+          .map(Number)
+          .filter(value => !Number.isNaN(value))
 
-        if (typeof firstValue === 'undefined') {
-          return undefined
-        }
-
-        let facetedMinMaxValues: [any, any] = [firstValue, firstValue]
-
-        for (let i = 0; i < facetedRowModel.flatRows.length; i++) {
-          const values =
-            facetedRowModel.flatRows[i]!.getUniqueValues<number>(columnId)
+        if (!uniqueValues.length) return
 
-          for (let j = 0; j < values.length; j++) {
-            const value = values[j]!
+        let facetedMinValue = uniqueValues[0]!
+        let facetedMaxValue = uniqueValues[uniqueValues.length - 1]!
 
-            if (value < facetedMinMaxValues[0]) {
-              facetedMinMaxValues[0] = value
-            } else if (value > facetedMinMaxValues[1]) {
-              facetedMinMaxValues[1] = value
-            }
-          }
+        for (const value of uniqueValues) {
+          if (value < facetedMinValue) facetedMinValue = value
+          else if (value > facetedMaxValue) facetedMaxValue = value
         }
 
-        return facetedMinMaxValues
+        return [facetedMinValue, facetedMaxValue]
       },
       getMemoOptions(table.options, 'debugTable', 'getFacetedMinMaxValues')
     )
