fix(ui5-table): remove circular dependency from table and row#9261
fix(ui5-table): remove circular dependency from table and row#9261
Conversation
- remove cyclic import in TableRowBase of Table.ts - add TableUtils.ts, which adds duck-typed instanceof checks for safe imports
- remove cyclic import in TableRowBase of Table.ts - add TableUtils.ts, which adds duck-typed instanceof checks for safe imports
| return this; | ||
| } | ||
|
|
||
| isTableCellBase() { |
There was a problem hiding this comment.
I do not get this idea and what is wrong with instanceof check? a very fundamental feature is taken from our hands and this is ok?
There was a problem hiding this comment.
@nnaydenow linked me this PR: #8822 referencing point 4.
Seems like the main issue is scoping, when you have multiple different instances of the framework in your application, instanceof is not that reliable anymore?
aborjinik
left a comment
There was a problem hiding this comment.
How about setting an attribute in the onEnterDom of base classes and check this attribute to determine?
For the Table this should not be necessary since the framework does this anyway.
|
@aborjinik We can certainly try that. It would be different to how other components would handle this, but I think the Table structure and its components is anyways pretty different to the existing components. I'll try to implement the change in this PR: #9205 |
Fixes: #9247