Skip to content

emacs: use held back patchelf_0_15 to avoid upstream bug#221900

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
trofi:emacs-on-older-patchelf
Mar 19, 2023
Merged

emacs: use held back patchelf_0_15 to avoid upstream bug#221900
vcunat merged 1 commit intoNixOS:staging-nextfrom
trofi:emacs-on-older-patchelf

Conversation

@trofi
Copy link
Copy Markdown
Contributor

@trofi trofi commented Mar 18, 2023 •
edited by vcunat
Loading

patchelf-0.17.2 corrupts $out/bin/emacs binary. It has something to do with program headers change. Let's pin emacs back to 0.15.0 until patchelf is fixed.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@trofi
emacs: use held back patchelf_0_15 to avoid upstream bug
114bccd 
patchelf-0.17.2 corrupts `$out/bin/emacs` binary. It has something to
do with program headers change. Let's pin `emcas` back to `0.15.0`
until `patchelf` is fixed.
@trofi trofi requested a review from adisbladis as a code owner March 18, 2023 21:22
@github-actions github-actions bot added the 6.topic: emacs Text editor label Mar 18, 2023
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 18, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 18, 2023
fabianhjr
fabianhjr approved these changes Mar 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@fabianhjr fabianhjr left a comment •
edited by trofi
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested with:

    emacs = {
      enable = true;
      package = pkgs.emacs28NativeComp;
      extraPackages = epkgs:
        with epkgs; [
          # agda2-mode # Needs to be from same build as agda
          vterm
        ];
    };

on staging-next

@vcunat
Copy link
Copy Markdown
Member

vcunat commented Mar 19, 2023

It bothers me that the corruption didn't get detected within build of the corrupted package. Therefore we might have more of these cases that don't get detected at Hydra. Well, maybe it's OK-ish uncertainty for nixpkgs master. Either way I hope the bug can be analyzed and fixed quickly upstream.

@vcunat vcunat merged commit ce7e136 into NixOS:staging-next Mar 19, 2023
@trofi trofi deleted the emacs-on-older-patchelf branch March 19, 2023 09:29
@trofi trofi mentioned this pull request Mar 19, 2023
Closed
vcunat added a commit that referenced this pull request Mar 20, 2023
@vcunat
Revert "Merge #221900: emacs: use patchelf_0_15 to avoid upstream bug"
df0d3e3 
This reverts commit ce7e136, reversing
changes made to 4d82a45.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianhjr fabianhjr fabianhjr approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@Atemu Atemu Awaiting requested review from Atemu

@jwiegley jwiegley Awaiting requested review from jwiegley

@lovek323 lovek323 Awaiting requested review from lovek323

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@edolstra edolstra Awaiting requested review from edolstra

Assignees

No one assigned

Labels

6.topic: emacs Text editor 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trofi @vcunat @fabianhjr