Fix assertion functions accessed via wildcard imports#51324
Merged
jakebailey merged 4 commits intomicrosoft:mainfrom Oct 28, 2022
Merged
Fix assertion functions accessed via wildcard imports#51324jakebailey merged 4 commits intomicrosoft:mainfrom
jakebailey merged 4 commits intomicrosoft:mainfrom
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35004
This comes down to us resolving the symbol in some conditions but not others, which led to an inconsistent experience; these assertions were legal so long as the leftmost symbol wasn't a namespace import. If you imported a wildcard import via another module's named exports, it was legal, but using a wildcard import to access that same export was not.
Hoping to get this in to 4.9 so it can in be our LKG for 5.0; this will allow me to convert the Debug namespace into a module (which will then enable scope hoisting and perf boosts).