Add origin and rpID in authentication and registration info#415
Merged
MasterKale merged 3 commits intoMasterKale:masterfrom Jul 27, 2023
Merged
Conversation
Owner
I'd change the
Then in |
Author
|
@MasterKale thanks for the tip, good to go now 👍 |
MasterKale
requested changes
Jul 20, 2023
packages/server/src/authentication/verifyAuthenticationResponse.ts
Outdated
Show resolved
Hide resolved
6e0421f to
57f58b8
Compare
MasterKale
requested changes
Jul 20, 2023
Owner
MasterKale
left a comment
There was a problem hiding this comment.
Thanks for handling all my comments @Mikescops! Just a couple more around refining tests and then I think this is good to go 🚀
packages/server/src/authentication/verifyAuthenticationResponse.test.ts
Outdated
Show resolved
Hide resolved
packages/server/src/authentication/verifyAuthenticationResponse.test.ts
Outdated
Show resolved
Hide resolved
packages/server/src/registration/verifyRegistrationResponse.test.ts
Outdated
Show resolved
Hide resolved
MasterKale
reviewed
Jul 20, 2023
Author
|
I think it's mergeable now 👍 cc @MasterKale |
MasterKale
approved these changes
Jul 27, 2023
Owner
MasterKale
left a comment
There was a problem hiding this comment.
Thanks for the nudge @Mikescops, I'll go ahead and merge this ✌️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now I only added the origin to the response.
The rpID is hashed, I'm not sure it is super relevant, what do you think @MasterKale ?
Closes #414