Skip to content

feat/json-type-updates#400

Merged
MasterKale merged 5 commits intomasterfrom
feat/json-type-updates
Jun 25, 2023
Merged

feat/json-type-updates#400
MasterKale merged 5 commits intomasterfrom
feat/json-type-updates

Conversation

@MasterKale
Copy link
Owner

@MasterKale MasterKale commented Jun 25, 2023

I just went through all the types JSON types in @simplewebauthn/typescript-types and matched them against the latest L3 draft and almost everything looks good:

Screenshot 2023-06-25 at 9 05 43 AM

...Except for missing additions of the "convenience values" publicKeyAlgorithm, publicKey, and authenticatorData on AuthenticatorAttestationResponseJSON. These values come from the correspondingly-named get...() methods on AuthenticatorAttestationResponse.

The types deviate a bit from what's in L3 because 1) L3 isn't the Recommendation yet, and 2) browser compatibility is still a little spotty (MDN says Firefox doesn't really support the getters):

This PR will return the values in the output from browser's startRegistration() when their corresponding getter methods are available.

Fixes #384.

@MasterKale MasterKale added this to the v7.4.0 milestone Jun 25, 2023
@MasterKale MasterKale added enhancement New feature or request package:browser @simplewebauthn/browser package:types @simplewebauthn/typescript-types and removed enhancement New feature or request labels Jun 25, 2023
@MasterKale MasterKale merged commit 67aad75 into master Jun 25, 2023
@MasterKale MasterKale deleted the feat/json-type-updates branch June 25, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:browser @simplewebauthn/browser package:types @simplewebauthn/typescript-types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confirm accuracy of JSON interfaces in light of recent spec PR's

1 participant