Merged
Conversation
82b4591 to
8c3fe5b
Compare
Member
|
I think it's worthwhile to port the LegacyHoverEventSerializer and text-serializer-gson-legacy-impl over to With options, I think it's worthwhile to have a common builder interface exposed as well -- since there are a few configurable elements. I'm not sure what your goals were with the |
ee315f8 to
8d02986
Compare
This allows common implemenattions to be used across serializer implementations.
zml2008
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new module providing an implementation agnostic JSON serializer. The intention behind this PR is to allow platforms to swap between or use alternative implementations of a json serializer (see #839) whilst still allowing consumers of the platform to work regardless of the backing impl.
work that needs doing:
[ ] do we want a common flavour of thenot worth doing in this first revisionProviderservices that normal serializers have, intended to be implemented by platforms?