Skip to content

minor fix for document#2979

Merged
IgnatBeresnev merged 2 commits intoKotlin:masterfrom
LiYing2010:fix_doc
Apr 26, 2023
Merged

minor fix for document#2979
IgnatBeresnev merged 2 commits intoKotlin:masterfrom
LiYing2010:fix_doc

Conversation

@LiYing2010
Copy link
Copy Markdown
Contributor

@LiYing2010 LiYing2010 commented Apr 24, 2023

Change List

minor fix for documents: typo, code style

Copy link
Copy Markdown
Contributor

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for fixing a bunch of small inconsistencies, I would've never noticed these!

Comment thread docs/topics/dokka-plugins.md Outdated
Comment thread docs/topics/dokka-plugins.md Outdated
@LiYing2010
Copy link
Copy Markdown
Contributor Author

@IgnatBeresnev

I have reverted changes for idents,
but there are 2 commits in this PR now,
do you want me rebase and force-push this PR, so I can make the commit history more beautiful?

@IgnatBeresnev
Copy link
Copy Markdown
Contributor

Once again, thank you! 👍 👍

I have reverted changes for idents,
but there are 2 commits in this PR now,
do you want me rebase and force-push this PR, so I can make the commit history more beautiful?

We use GitHub's "Squash and merge", so there will be a single merge commit anyway, no need to do anything yourself, but thanks for asking and willing to do it :)

@IgnatBeresnev IgnatBeresnev merged commit 1632ff3 into Kotlin:master Apr 26, 2023
@LiYing2010 LiYing2010 deleted the fix_doc branch April 27, 2023 04:19
@LiYing2010
Copy link
Copy Markdown
Contributor Author

Thank you
I am glad I can help a little

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants