Use Gradle filesystem types for task properties#2707
Merged
IgnatBeresnev merged 3 commits intoKotlin:masterfrom Feb 27, 2023
Merged
Use Gradle filesystem types for task properties#2707IgnatBeresnev merged 3 commits intoKotlin:masterfrom
IgnatBeresnev merged 3 commits intoKotlin:masterfrom
Conversation
Additionally add workaround functions for the SamWithReceiver bug.
cf4e9f3 to
20cc9dd
Compare
IgnatBeresnev
approved these changes
Feb 23, 2023
Contributor
IgnatBeresnev
left a comment
There was a problem hiding this comment.
Thanks for the documentation links and the explanations! Studing your PRs, I'm definitely starting to get the hang of how a good Gradle plugin should look like
I've started lengthy integration tests, will merge the PR once they pass
Contributor
|
Integration tests are all good 🎉 @aSemy could you please resolve conflicts? I'll merge it right after |
# Conflicts: # runners/gradle-plugin/src/main/kotlin/org/jetbrains/dokka/gradle/DokkaMultiModuleFileLayout.kt # runners/gradle-plugin/src/main/kotlin/org/jetbrains/dokka/gradle/tasks/AbstractDokkaTask.kt # runners/gradle-plugin/src/main/kotlin/org/jetbrains/dokka/gradle/tasks/DokkaCollectorTask.kt # runners/gradle-plugin/src/main/kotlin/org/jetbrains/dokka/gradle/tasks/DokkaMultiModuleTask.kt # runners/gradle-plugin/src/main/kotlin/org/jetbrains/dokka/gradle/tasks/DokkaTask.kt # runners/gradle-plugin/src/main/kotlin/org/jetbrains/dokka/gradle/tasks/DokkaTaskPartial.kt # runners/gradle-plugin/src/test/kotlin/org/jetbrains/dokka/gradle/DokkaMultiModuleFileLayoutTest.kt # runners/gradle-plugin/src/test/kotlin/org/jetbrains/dokka/gradle/KotlinDslDokkaTaskConfigurationTest.kt # runners/gradle-plugin/src/test/kotlin/org/jetbrains/dokka/gradle/tasks/DokkaMultiModuleTaskTest.kt
Contributor
|
(sorry, I had merged a small conflict and I couldn't resist trying out the web interface for resolving them 😅 quite neat!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #2700
Using Gradle filesystem types allows for more idiomatic usage of Gradle, and makes it easier to wire task inputs and outputs together.
I changed these properties to be managed types, as they are easier to create.
I also started moving some of the conventional values for these properties into DokkaPlugin. I intend to move more of this property convention into DokkaPlugin, as this makes it easier to re-use properties and values, and wire tasks together. When the conventions are set inside a Task, they are limited by what they can access from the
projectinstance, which can make for repetitive or tough to follow code.This PR includes changes from