Add Cpp Project Icon#655
Merged
KirillOsenkov merged 2 commits intoKirillOsenkov:mainfrom Feb 14, 2023
Merged
Conversation
yuehuang010
commented
Feb 14, 2023
| result = evaluation.ProjectFileExtension; | ||
| } | ||
|
|
||
| if (result != null && result != ".sln" && result != ".csproj") |
Contributor
Author
There was a problem hiding this comment.
This original code seems odd to single out csproj. Is there a reason?
Owner
There was a problem hiding this comment.
no, it just forgets other project formats. I can't remember if we have a helper that stores all known project file extensions.
KirillOsenkov
approved these changes
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add double click on Meta Project message that will open the metaproject file.
Fix missing vb and fs project icons from search results.
Add Cpp Project Icon.