Optimize NuGet package dependencies.#650
Merged
KirillOsenkov merged 5 commits intoKirillOsenkov:mainfrom Jan 28, 2023
teo-tsirpanis:msbuild-tasks
Merged
Optimize NuGet package dependencies.#650KirillOsenkov merged 5 commits intoKirillOsenkov:mainfrom teo-tsirpanis:msbuild-tasks
KirillOsenkov merged 5 commits intoKirillOsenkov:mainfrom
teo-tsirpanis:msbuild-tasks
Conversation
KirillOsenkov
approved these changes
Jan 28, 2023
Owner
|
Hmm, wait, I'm getting a build failure:
The viewer project (StructuredLogViewer.csproj) does depend on Microsoft.Build.Tasks.Core.dll because it ships it with the app: I think we'll need to add the Tasks.Core PackageReference to StructuredLogViewer.csproj |
KirillOsenkov
requested changes
Jan 28, 2023
Owner
KirillOsenkov
left a comment
There was a problem hiding this comment.
Need to add a PackageReference to Tasks to StructuredLogViewer.csproj so that the build succeeds
Microsoft.Build.Tasks.Core.
Contributor
Author
|
CI is green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #649.